Page MenuHomePhabricator
Differential D12353

Make buildPagingClauseFromMultipleColumns() safer
ClosedPublic
Actions

Authored by epriestley on Apr 12 2015, 12:52 AM.
Tags
None
Referenced Files
F19095571: D12353.diff
Thu, Dec 4, 5:42 AM
F18855517: D12353.id.diff
Nov 1 2025, 5:28 AM
F18809122: D12353.id.diff
Oct 19 2025, 11:21 AM
F18806326: D12353.diff
Oct 18 2025, 6:59 PM
F18657722: D12353.id29674.diff
Sep 23 2025, 3:08 AM
F18574616: D12353.id.diff
Sep 10 2025, 11:16 AM
F18505337: D12353.id.diff
Sep 5 2025, 12:35 AM
F18497113: D12353.diff
Sep 4 2025, 5:52 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7803: Implement a composite query which unifies cursor paging across subqueries
Commits
Restricted Diffusion Commit
rP604d1409f16f: Make buildPagingClauseFromMultipleColumns() safer
Summary

Ref T7803. Reduce the amount of code we're trusting to build SQL queries.

Test Plan
  • Paged through results in Maniphest, Differential and Diffusion.
  • Some of the NULLable groups in Maniphest are a bit funky but this was preexisting.

Diff Detail

Repository
rP Phabricator
Branch
rpaging3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5235
Build 5253: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29674.Apr 12 2015, 12:52 AM
epriestley retitled this revision from to Make buildPagingClauseFromMultipleColumns() safer.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7803: Implement a composite query which unifies cursor paging across subqueries.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 12 2015, 12:52 AM
epriestley updated this revision to Diff 29675.Apr 12 2015, 12:54 AM
  • Also align documentation.
btrahan accepted this revision.Apr 13 2015, 5:07 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 5:07 PM
Closed by commit rP604d1409f16f: Make buildPagingClauseFromMultipleColumns() safer (authored by epriestley, committed by epriestley). · Explain WhyApr 13 2015, 7:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
query/
9 lines
maniphest/
query/
44 lines
repository/
query/
15 lines
infrastructure/
query/
policy/
31 lines

Diff 29675

View Options

src/applications/differential/query/DifferentialRevisionQuery.php

Loading...
View Options

src/applications/maniphest/query/ManiphestTaskQuery.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryQuery.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility