Page MenuHomePhabricator

Make buildPagingClauseFromMultipleColumns() safer
ClosedPublic

Authored by epriestley on Apr 12 2015, 12:52 AM.
Tags
None
Referenced Files
F15472225: D12353.id.diff
Sat, Apr 5, 11:38 AM
F15469996: D12353.diff
Fri, Apr 4, 6:52 PM
F15442114: D12353.id29674.diff
Wed, Mar 26, 9:34 PM
F15421934: D12353.id29674.diff
Sat, Mar 22, 3:43 AM
F15395817: D12353.diff
Sun, Mar 16, 9:54 AM
F15375335: D12353.id29675.diff
Wed, Mar 12, 10:39 PM
F15334726: D12353.diff
Sat, Mar 8, 11:42 AM
Unknown Object (File)
Feb 27 2025, 4:47 AM
Subscribers

Details

Summary

Ref T7803. Reduce the amount of code we're trusting to build SQL queries.

Test Plan
  • Paged through results in Maniphest, Differential and Diffusion.
  • Some of the NULLable groups in Maniphest are a bit funky but this was preexisting.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make buildPagingClauseFromMultipleColumns() safer.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 5:07 PM
This revision was automatically updated to reflect the committed changes.