Page MenuHomePhabricator
Differential D12315

Restructure cache checks to improve modularity
ClosedPublic
Actions

Authored by epriestley on Apr 7 2015, 8:41 PM.
Tags
None
Referenced Files
F13162595: D12315.diff
Mon, May 6, 2:29 PM
Unknown Object (File)
Fri, May 3, 10:08 AM
Unknown Object (File)
Fri, May 3, 10:08 AM
Unknown Object (File)
Thu, Apr 25, 3:34 AM
Unknown Object (File)
Sun, Apr 21, 2:40 AM
Unknown Object (File)
Thu, Apr 11, 5:56 PM
Unknown Object (File)
Thu, Apr 11, 9:36 AM
Unknown Object (File)
Apr 2 2024, 9:20 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T5501: Provide a builtin APC / OpCache diagnostics page and improve OpCache support
Commits
Restricted Diffusion Commit
rP0880788bd4cf: Restructure cache checks to improve modularity
Summary

Ref T5501. This code was headed down a bad road; dump an indirection layer between rendering and data gatehring.

In particular, this will make it much easier to lift these issues into setup warnings eventually.

Test Plan

Viewed cache status page.

Diff Detail

Repository
rP Phabricator
Branch
cache2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5183
Build 5201: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29588.Apr 7 2015, 8:41 PM
epriestley retitled this revision from to Restructure cache checks to improve modularity.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5501: Provide a builtin APC / OpCache diagnostics page and improve OpCache support.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 7 2015, 8:41 PM
btrahan accepted this revision.Apr 7 2015, 9:02 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 7 2015, 9:02 PM
Closed by commit rP0880788bd4cf: Restructure cache checks to improve modularity (authored by epriestley, committed by epriestley). · Explain WhyApr 7 2015, 9:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 29588

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/cache/spec/PhabricatorCacheSpec.php

Loading...
View Options

src/applications/cache/spec/PhabricatorDataCacheSpec.php

Loading...
View Options

src/applications/cache/spec/PhabricatorOpcodeCacheSpec.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigCacheController.php

Loading...
Phabricator · Built by Phacility