Page MenuHomePhabricator

Conpherence - implement PhabricatorDestructibleInterface so threads can be deleted
ClosedPublic

Authored by btrahan on Apr 6 2015, 6:18 PM.
Tags
None
Referenced Files
F19805914: D12304.id29546.diff
Tue, Mar 3, 12:19 AM
F19337059: D12304.id.diff
Dec 25 2025, 8:58 PM
F19154291: D12304.id29546.diff
Dec 11 2025, 2:11 PM
F18869149: D12304.diff
Nov 4 2025, 10:05 AM
F18823870: D12304.id.diff
Oct 23 2025, 1:38 PM
F18821888: D12304.diff
Oct 23 2025, 2:27 AM
F18716924: D12304.id29633.diff
Sep 29 2025, 12:53 PM
F18708334: D12304.id29546.diff
Sep 28 2025, 9:24 PM
Subscribers

Details

Summary

Fixes T7694. I had to complicate the ConpherenceThreadQuery code slightly so that if we specify id(s) or phid(s) then we don't bother with all that join stuff we need to make sure we have a reasonable query in production.

Test Plan

bin/remove destroy ZXX worked! tried to visit ZXX and got a nice 404. Clicked around and couldn't find anything broken because of the deletion

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Conpherence - implement PhabricatorDestructibleInterface so threads can be deleted.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 8 2015, 7:19 PM
This revision was automatically updated to reflect the committed changes.