Page MenuHomePhabricator
Differential D12301

Remove monospaced font preference global defaults
ClosedPublic
Actions

Authored by epriestley on Apr 6 2015, 2:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 5, 2:00 AM
Unknown Object (File)
Nov 5 2024, 7:35 AM
Unknown Object (File)
Oct 25 2024, 3:59 AM
Unknown Object (File)
Oct 22 2024, 5:03 PM
Unknown Object (File)
Oct 21 2024, 2:31 PM
Unknown Object (File)
Oct 18 2024, 2:36 AM
Unknown Object (File)
Oct 15 2024, 1:06 AM
Unknown Object (File)
Sep 25 2024, 2:45 AM
View All Files
Subscribers
chad
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T7764: Default monospaced font shows as blank
Commits
Restricted Diffusion Commit
rP7aebd2388f7c: Remove monospaced font preference global defaults
Summary

Fixes T7764. These settings have low utility, are no longer used by default, have become less useful on modern Windows which has a better selection of available fonts, and will eventually be subsumed (at least, for the most part) by T4103.

Test Plan
  • Grepped for strings.
  • Viewed settings.
  • Changed font to "24px impact".
  • Viewed diffs with default and custom font.

Diff Detail

Repository
rP Phabricator
Branch
monodef
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5156
Build 5174: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29531.Apr 6 2015, 2:52 PM
epriestley retitled this revision from to Remove monospaced font preference global defaults.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7764: Default monospaced font shows as blank.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 6 2015, 2:52 PM
chad accepted this revision.Apr 6 2015, 3:06 PM
chad added a reviewer: chad.
chad added a subscriber: chad.

99 bottles of beer on the wall...

This revision is now accepted and ready to land.Apr 6 2015, 3:06 PM
Closed by commit rP7aebd2388f7c: Remove monospaced font preference global defaults (authored by epriestley, committed by epriestley). · Explain WhyApr 6 2015, 3:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 29531

View Options

src/applications/config/check/PhabricatorExtraConfigSetupCheck.php

Loading...
View Options

src/applications/config/option/PhabricatorSyntaxHighlightingConfigOptions.php

Loading...
View Options

src/applications/settings/panel/PhabricatorDisplayPreferencesSettingsPanel.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
Phabricator · Built by Phacility