Page MenuHomePhabricator

Allow "send me an email" in personal rules to punch through settings
ClosedPublic

Authored by epriestley on Apr 6 2015, 2:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 6:24 PM
Unknown Object (File)
Fri, Dec 13, 11:54 AM
Unknown Object (File)
Thu, Dec 12, 5:03 PM
Unknown Object (File)
Mon, Dec 9, 12:34 AM
Unknown Object (File)
Fri, Nov 22, 6:10 AM
Unknown Object (File)
Thu, Nov 21, 9:47 AM
Unknown Object (File)
Wed, Nov 20, 8:28 AM
Unknown Object (File)
Nov 15 2024, 6:50 PM
Subscribers

Details

Summary

Fixes T7731. When a user writes a "Send me an email" rule, always try send them an email, even if their notification settings would normally downgrade it to a notification.

In particular, this is stronger than these downgrades:

  • Downgrades due to "self actions";
  • downgrades due to "mail tags".
Test Plan
  • Wrote various Herald rules with "Send me an email" rules.
  • Used bin/mail list-outbound / show-outbound to vet generated mail.
  • Mail reacted properly to a variety of conditions (disabled accounts, settings, "send me an email" rule, forced delivery).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow "send me an email" in personal rules to punch through settings.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 6 2015, 4:22 PM
This revision was automatically updated to reflect the committed changes.