Page MenuHomePhabricator

Make mail delivery reasons code-based; include positive and negative reasons

Authored by epriestley on Apr 5 2015, 5:46 PM.



Ref T7731. Looking forward to T5791, I eventually anticipate writing an interface which looks like a webmail UI where users can review mail they've been sent and understand why they recieved (or did not receive) the mail. Roughly like bin/mail list-outbound / bin/mail show-outbound work today, but policy-aware (so you can only see messages where delivery was attempted to you).

We currently record a list of "reasons" why a mail is undeliverable, but this list is string-based (so it can not be translated once we start persisting it) and has only negative reasons (so it can not be used to fully understand reasons for delivery or nondelivery).

Make it code-based (so it can be translated) and allow both positive and negative reasons to be listed (so positive reasons can be understood).

Test Plan

Used bin/mail show-outbound to review mail delivery reasons, including the positive reason we currently have (forced delivery of authentication mail).

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 29524.Apr 5 2015, 5:46 PM
epriestley retitled this revision from to Make mail delivery reasons code-based; include positive and negative reasons.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan accepted this revision.Apr 6 2015, 4:20 PM
btrahan edited edge metadata.


This revision is now accepted and ready to land.Apr 6 2015, 4:20 PM
This revision was automatically updated to reflect the committed changes.