Page MenuHomePhabricator
Differential D12273

Linter fixes for XHPAST source
ClosedPublic
Actions

Authored by joshuaspence on Apr 4 2015, 6:29 AM.
Tags
None
Referenced Files
F15538129: D12273.diff
Thu, Apr 24, 5:30 PM
F15532729: D12273.id29471.diff
Wed, Apr 23, 5:05 PM
F15524187: D12273.id29471.diff
Mon, Apr 21, 6:29 AM
F15519014: D12273.id.diff
Sat, Apr 19, 7:00 PM
F15516297: D12273.diff
Fri, Apr 18, 5:47 PM
F15487133: D12273.diff
Thu, Apr 10, 11:30 AM
F15455115: D12273.id29471.diff
Mar 29 2025, 10:19 PM
F15425928: D12273.id29482.diff
Mar 23 2025, 6:39 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUcc66c966346c: Linter fixes for XHPAST source
Summary

See D12272#121803.

Test Plan

Admittedly, I don't know much about C/C++, so this could likely be wrong. I ran arc unit --everything to verify that nothing was majorly broken.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 29471.Apr 4 2015, 6:29 AM
joshuaspence retitled this revision from to Linter fixes for XHPAST source.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 4 2015, 6:29 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 4 2015, 11:58 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 4 2015, 11:58 AM
Closed by commit rPHUcc66c966346c: Linter fixes for XHPAST source (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 5 2015, 6:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
support/
xhpast/
17 lines
11 lines
121 lines
40 lines
11 lines

Diff 29482

View Options

support/xhpast/ast.hpp

Loading...
View Options

support/xhpast/astnode.hpp

Loading...
View Options

support/xhpast/parser.y

Loading...
View Options

support/xhpast/scanner.l

Loading...
View Options

support/xhpast/xhpast.cpp

Loading...
Phabricator · Built by Phacility