Page MenuHomePhabricator
Differential D12273

Linter fixes for XHPAST source
ClosedPublic
Actions

Authored by joshuaspence on Apr 4 2015, 6:29 AM.
Tags
None
Referenced Files
F13990623: D12273.diff
Tue, Oct 22, 5:05 AM
F13988277: D12273.id29482.diff
Mon, Oct 21, 2:25 PM
F13985509: D12273.id29471.diff
Sun, Oct 20, 9:02 PM
Unknown Object (File)
Sep 21 2024, 2:19 AM
Unknown Object (File)
Sep 13 2024, 6:13 AM
Unknown Object (File)
Sep 12 2024, 4:31 AM
Unknown Object (File)
Sep 12 2024, 4:30 AM
Unknown Object (File)
Sep 12 2024, 4:29 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUcc66c966346c: Linter fixes for XHPAST source
Summary

See D12272#121803.

Test Plan

Admittedly, I don't know much about C/C++, so this could likely be wrong. I ran arc unit --everything to verify that nothing was majorly broken.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 29471.Apr 4 2015, 6:29 AM
joshuaspence retitled this revision from to Linter fixes for XHPAST source.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 4 2015, 6:29 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 4 2015, 11:58 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 4 2015, 11:58 AM
Closed by commit rPHUcc66c966346c: Linter fixes for XHPAST source (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 5 2015, 6:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
support/
xhpast/
17 lines
11 lines
121 lines
40 lines
11 lines

Diff 29482

View Options

support/xhpast/ast.hpp

Loading...
View Options

support/xhpast/astnode.hpp

Loading...
View Options

support/xhpast/parser.y

Loading...
View Options

support/xhpast/scanner.l

Loading...
View Options

support/xhpast/xhpast.cpp

Loading...
Phabricator · Built by Phacility