Page MenuHomePhabricator

Enforce that global locks have keys shorter than 64 characters
ClosedPublic

Authored by epriestley on Apr 2 2015, 4:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 14 2024, 5:19 AM
Unknown Object (File)
Feb 14 2024, 5:18 AM
Unknown Object (File)
Feb 14 2024, 5:18 AM
Unknown Object (File)
Feb 7 2024, 3:09 PM
Unknown Object (File)
Feb 3 2024, 8:09 PM
Unknown Object (File)
Feb 3 2024, 5:55 PM
Unknown Object (File)
Jan 24 2024, 3:12 AM
Unknown Object (File)
Jan 8 2024, 5:24 PM
Subscribers

Details

Summary

Fixes T7484. There's a bunch of spooky mystery here but the current behavior can probably cause problems in at least some situations.

Also moves a couple callsigns to monograms (see T4245).

Test Plan
  • Faked a short lock length to hit the exception.
  • Updated normally.
  • Grepped for other use sites, none seemed suspicious or likely to overflow the lock length.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Enforce that global locks have keys shorter than 64 characters.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 2 2015, 8:07 PM
This revision was automatically updated to reflect the committed changes.