Page MenuHomePhabricator
Differential D12237

Subclass most ReplyHandlers from TransactionReplyHandler
ClosedPublic
Actions

Authored by epriestley on Apr 1 2015, 2:08 AM.
Tags
None
Referenced Files
F15666915: D12237.diff
Sun, May 25, 9:12 AM
F15661435: D12237.id.diff
Sat, May 24, 3:50 PM
Unknown Object (File)
Wed, May 21, 6:36 PM
Unknown Object (File)
Apr 20 2025, 4:54 PM
Unknown Object (File)
Apr 20 2025, 1:48 PM
Unknown Object (File)
Apr 19 2025, 6:03 PM
Unknown Object (File)
Apr 11 2025, 11:52 PM
Unknown Object (File)
Mar 28 2025, 10:34 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7199: Expand the power of "!action" commands in email
Commits
Restricted Diffusion Commit
rP7c5f71b6914c: Subclass most ReplyHandlers from TransactionReplyHandler
Summary

Ref T7199. Half of these aren't even reachable, but make some progress toward reducing the amount of nonsense and garbage in mail handling.

Test Plan

Tested all reachable handlers with bin/mail receive-test.

Diff Detail

Repository
rP Phabricator
Branch
mcom9
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/audit/mail/PhabricatorAuditReplyHandler.php:13XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 5074
Build 5092: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29396.Apr 1 2015, 2:08 AM
epriestley retitled this revision from to Subclass most ReplyHandlers from TransactionReplyHandler.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7199: Expand the power of "!action" commands in email.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 1 2015, 2:08 AM
btrahan accepted this revision.Apr 1 2015, 3:08 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 1 2015, 3:08 PM
Closed by commit rP7c5f71b6914c: Subclass most ReplyHandlers from TransactionReplyHandler (authored by epriestley, committed by epriestley). · Explain WhyApr 1 2015, 3:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
20 lines
applications/
audit/
mail/
44 lines
files/
mail/
42 lines
fund/
mail/
17 lines
legalpad/
mail/
58 lines
storage/
4 lines
macro/
mail/
17 lines
pholio/
mail/
17 lines
phortune/
mail/
17 lines
phriction/
mail/
20 lines
ponder/
mail/
15 lines
releeph/
mail/
38 lines

Diff 29396

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/audit/mail/PhabricatorAuditReplyHandler.php

Loading...
View Options

src/applications/files/mail/FileReplyHandler.php

Loading...
View Options

src/applications/fund/mail/FundInitiativeReplyHandler.php

Loading...
View Options

src/applications/legalpad/mail/LegalpadReplyHandler.php

Loading...
View Options

src/applications/legalpad/storage/LegalpadTransactionComment.php

Loading...
View Options

src/applications/macro/mail/PhabricatorMacroReplyHandler.php

Loading...
View Options

src/applications/pholio/mail/PholioReplyHandler.php

Loading...
View Options

src/applications/phortune/mail/PhortuneCartReplyHandler.php

Loading...
View Options

src/applications/phriction/mail/PhrictionReplyHandler.php

Loading...
View Options

src/applications/ponder/mail/PonderQuestionReplyHandler.php

Loading...
View Options

src/applications/releeph/mail/ReleephRequestReplyHandler.php

Loading...
Phabricator · Built by Phacility