Page MenuHomePhabricator
Differential D12236

Lift common code for transaction-based reply handlers into parent class
ClosedPublic
Actions

Authored by epriestley on Apr 1 2015, 1:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 12:07 AM
Unknown Object (File)
Fri, Nov 22, 4:00 AM
Unknown Object (File)
Sun, Nov 17, 9:13 PM
Unknown Object (File)
Sat, Nov 16, 11:03 PM
Unknown Object (File)
Sat, Nov 9, 10:19 PM
Unknown Object (File)
Wed, Nov 6, 1:52 AM
Unknown Object (File)
Oct 27 2024, 5:15 PM
Unknown Object (File)
Oct 26 2024, 11:34 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7199: Expand the power of "!action" commands in email
Commits
Restricted Diffusion Commit
rP161f936871b8: Lift common code for transaction-based reply handlers into parent class
Summary

Ref T7199. Essentially all of the reply handlers now apply transactions to something which implements PhabricatorApplicationTransactionInterface.

We can share code between them by lifting this stuff into a superclass.

First, convert paste. Also rename PasteMockMailReceiver to PasteMailReceiver (this got mis-copied from Pholio at some point, I think).

Test Plan

Used bin/mail receive-test to send comments + !unsubscribe to pastes.

Diff Detail

Repository
rP Phabricator
Branch
mcom8
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/transactions/replyhandler/PhabricatorApplicationTransactionReplyHandler.php:88XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 5073
Build 5091: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29395.Apr 1 2015, 1:51 AM
epriestley retitled this revision from to Lift common code for transaction-based reply handlers into parent class.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7199: Expand the power of "!action" commands in email.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 1 2015, 1:51 AM
btrahan accepted this revision.Apr 1 2015, 3:07 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 1 2015, 3:07 PM
Closed by commit rP161f936871b8: Lift common code for transaction-based reply handlers into parent class (authored by epriestley, committed by epriestley). · Explain WhyApr 1 2015, 3:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
8 lines
applications/
paste/
mail/
PasteMailReceiver.php
PasteMockMailReceiver.php
2 lines
46 lines
transactions/
replyhandler/
92 lines

Diff 29395

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/paste/mail/PasteMailReceiver.php

Loading...
View Options

src/applications/paste/mail/PasteMockMailReceiver.php

Loading...
View Options

src/applications/paste/mail/PasteReplyHandler.php

Loading...
View Options

src/applications/transactions/replyhandler/PhabricatorApplicationTransactionReplyHandler.php

Loading...
Phabricator · Built by Phacility