Page MenuHomePhabricator

Lift common code for transaction-based reply handlers into parent class
ClosedPublic

Authored by epriestley on Apr 1 2015, 1:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 3, 2:31 PM
Unknown Object (File)
Thu, Jan 2, 11:27 PM
Unknown Object (File)
Tue, Dec 31, 12:19 PM
Unknown Object (File)
Sat, Dec 28, 2:15 PM
Unknown Object (File)
Tue, Dec 24, 3:40 AM
Unknown Object (File)
Dec 15 2024, 11:26 PM
Unknown Object (File)
Dec 14 2024, 8:20 PM
Unknown Object (File)
Dec 4 2024, 2:12 AM
Subscribers

Details

Summary

Ref T7199. Essentially all of the reply handlers now apply transactions to something which implements PhabricatorApplicationTransactionInterface.

We can share code between them by lifting this stuff into a superclass.

First, convert paste. Also rename PasteMockMailReceiver to PasteMailReceiver (this got mis-copied from Pholio at some point, I think).

Test Plan

Used bin/mail receive-test to send comments + !unsubscribe to pastes.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Lift common code for transaction-based reply handlers into parent class.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 1 2015, 3:07 PM
This revision was automatically updated to reflect the committed changes.