Page MenuHomePhabricator

Move handle fetching into tokenizer Datasources

Authored by epriestley on Mar 31 2015, 1:47 PM.



Ref T7689. This serves two goals:

  • I want to remove Controller->loadViewerHandles(). A nontrivial number of these callsites are loading handles to pass to tokenizers. Since tokenizers need to take strings eventually anyway, we can do less work by letting them take PHIDs now.
  • A few changes out, I want tokenizers to accept parameterized tokens (like viewer(), members(differential), etc.), so the setValues() signature needs to change eventually anyway.

I made this work and converted a handful of callsites as an example; upcoming changes will convert more.

Test Plan
  • Viewed Almanac binding editor; used "Interface".
  • Edited Almanac services; used "Projects".
  • Edited Almanac devices; used "Projects".
  • Searched for commits; used "Auditors"; "Commit Authors", "Repositories".
  • Searched for calendar events; used "Created By"; used "Invited".

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Move handle fetching into tokenizer Datasources.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 31 2015, 8:44 PM
This revision was automatically updated to reflect the committed changes.