Page MenuHomePhabricator
Differential D12209

Remove implode_selected_handle_links()
ClosedPublic
Actions

Authored by epriestley on Mar 30 2015, 2:47 PM.
Tags
None
Referenced Files
F15624587: D12209.diff
Sat, May 17, 10:30 PM
Unknown Object (File)
Thu, May 8, 8:55 PM
Unknown Object (File)
Thu, May 8, 8:55 PM
Unknown Object (File)
Thu, May 8, 8:55 PM
Unknown Object (File)
Wed, May 7, 9:08 PM
Unknown Object (File)
Wed, May 7, 10:31 AM
Unknown Object (File)
Wed, Apr 30, 7:26 AM
Unknown Object (File)
Apr 17 2025, 4:02 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7689: Load handles just-in-time
Commits
Restricted Diffusion Commit
rP0f52fc771dc0: Remove implode_selected_handle_links()
Summary

Ref T7689. Use the newer, less-janky stuff for rendering handles.

Test Plan
  • Viewed a revision hovercard; viewed "Author", viewed "Reviewers", viewed "Tasks".
  • Viewed a task hovercard; viewed "Assigned To"; viewed "Projects"; viewed other edge fields.

Diff Detail

Repository
rP Phabricator
Branch
param6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5040
Build 5058: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29332.Mar 30 2015, 2:47 PM
epriestley retitled this revision from to Remove implode_selected_handle_links().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7689: Load handles just-in-time.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 30 2015, 2:47 PM
btrahan accepted this revision.Mar 30 2015, 8:05 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 30 2015, 8:05 PM
Closed by commit rP0f52fc771dc0: Remove implode_selected_handle_links() (authored by epriestley, committed by epriestley). · Explain WhyMar 31 2015, 12:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
event/
27 lines
maniphest/
event/
31 lines
phid/
handle/
view/

Diff 29332

View Options

src/applications/differential/event/DifferentialHovercardEventListener.php

Loading...
View Options

src/applications/maniphest/event/ManiphestHovercardEventListener.php

Loading...
View Options

src/applications/phid/handle/view/render.php

Loading...
Phabricator · Built by Phacility