Differential D12208

Remove Controller->renderHandlesForPHIDs()
ClosedPublic
Actions

Authored by epriestley on Mar 30 2015, 2:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, May 8, 8:54 PM

	Unknown Object (File)
	Thu, May 8, 8:54 PM

	Unknown Object (File)
	Thu, May 8, 8:54 PM

	Unknown Object (File)
	Wed, May 7, 10:31 AM

	Unknown Object (File)
	Apr 10 2025, 5:27 PM

	Unknown Object (File)
	Apr 9 2025, 9:24 AM

	Unknown Object (File)
	Apr 8 2025, 6:04 AM

	Unknown Object (File)
	Apr 7 2025, 8:04 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T7689: Load handles just-in-time

Commits

Restricted Diffusion Commit
rPe1eafd784e19: Remove Controller->renderHandlesForPHIDs()

Summary

Ref T7689. Remove all remaining callsites for this method.

Test Plan

Viewed a custom policy; viewed handles in the policy rules.
Viewed a Releeph product; viewed "Pushers".
Viewed a project; viewed "Watchers"; viewed "Members"; viewed "Looks Like".
Viewed repository edit; viewed "Credential"; viewed "Storage Service"; viewed "Projects".
Viewed repository detail; viewed "Projects".
Viewed commit; viewed (faked) "Reverts"; viewed (faked) "Reverted By".
- These are kind of a pain to generate so I faked 'em.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29331.Mar 30 2015, 2:40 PM

epriestley retitled this revision from to Remove Controller->renderHandlesForPHIDs().

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7689: Load handles just-in-time.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 30 2015, 2:40 PM

btrahan accepted this revision.Mar 30 2015, 8:04 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 30 2015, 8:04 PM

Closed by commit rPe1eafd784e19: Remove Controller->renderHandlesForPHIDs() (authored by epriestley, committed by epriestley). · Explain WhyMar 31 2015, 12:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

base/

controller/

PhabricatorController.php

24 lines

diffusion/

controller/

DiffusionCommitController.php

6 lines

DiffusionRepositoryController.php

3 lines

DiffusionRepositoryEditMainController.php

9 lines

phid/

view/

PHUIHandleListView.php

12 lines

PHUIHandleView.php

13 lines

project/

controller/

PhabricatorProjectProfileController.php

17 lines

releeph/

controller/

product/

ReleephProductViewController.php

6 lines

transactions/

controller/

PhabricatorApplicationTransactionValueController.php

12 lines

Diff 29356

src/applications/base/controller/PhabricatorController.php

Loading...

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...

src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php

Loading...

src/applications/phid/view/PHUIHandleListView.php

Loading...

src/applications/phid/view/PHUIHandleView.php

Loading...

src/applications/project/controller/PhabricatorProjectProfileController.php

Loading...

src/applications/releeph/controller/product/ReleephProductViewController.php

Loading...

src/applications/transactions/controller/PhabricatorApplicationTransactionValueController.php

Loading...