Page MenuHomePhabricator
Differential D12204

Remove Controller->getLoadedHandles()
ClosedPublic
Actions

Authored by epriestley on Mar 30 2015, 12:51 PM.
Tags
None
Referenced Files
F14356734: D12204.diff
Thu, Dec 19, 11:42 PM
Unknown Object (File)
Mon, Dec 9, 2:48 AM
Unknown Object (File)
Sun, Dec 8, 5:44 AM
Unknown Object (File)
Wed, Dec 4, 3:45 AM
Unknown Object (File)
Mon, Dec 2, 1:54 PM
Unknown Object (File)
Nov 18 2024, 11:52 PM
Unknown Object (File)
Nov 10 2024, 10:07 PM
Unknown Object (File)
Sep 9 2024, 12:43 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7689: Load handles just-in-time
Commits
Restricted Diffusion Commit
rP580590fcc9fd: Remove Controller->getLoadedHandles()
Summary

Ref T7689. Removes this part of the Controller->loadHandles() + Controller->getLoadedHandles() mechanism.

Test Plan
  • Viewed Herald transcripts.
  • Viewed Maniphest tasks with attached revisions and commits.

Diff Detail

Repository
rP Phabricator
Branch
param2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/maniphest/controller/ManiphestTaskDetailController.php:88XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 5035
Build 5053: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29327.Mar 30 2015, 12:51 PM
epriestley retitled this revision from to Remove Controller->getLoadedHandles().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7689: Load handles just-in-time.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 30 2015, 12:51 PM
btrahan accepted this revision.Mar 30 2015, 7:57 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 30 2015, 7:57 PM
Closed by commit rP580590fcc9fd: Remove Controller->getLoadedHandles() (authored by epriestley, committed by epriestley). · Explain WhyMar 31 2015, 12:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
base/
controller/
6 lines
herald/
adapter/
17 lines
controller/
6 lines
maniphest/
controller/
21 lines
phid/
handle/
pool/
14 lines

Diff 29327

View Options

src/applications/base/controller/PhabricatorController.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleViewController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/applications/phid/handle/pool/PhabricatorHandleList.php

Loading...
Phabricator · Built by Phacility