Fix 'Not Done' button hover state on inline comments
ClosedPublic
Actions

Authored by chad on Mar 28 2015, 5:42 PM.

Tags

None

Referenced Files

	F15546928: D12193.id.diff
	Sat, Apr 26, 5:28 PM

	F15532301: D12193.id29307.diff
	Wed, Apr 23, 3:28 PM

	F15526391: D12193.id.diff
	Mon, Apr 21, 8:43 PM

	F15507688: D12193.id.diff
	Tue, Apr 15, 9:58 PM

	F15495754: D12193.diff
	Sun, Apr 13, 5:32 AM

	F15473848: D12193.id29308.diff
	Sun, Apr 6, 2:03 AM

	F15471246: D12193.id29308.diff
	Sat, Apr 5, 4:13 AM

	F15432836: D12193.id29308.diff
	Mar 24 2025, 7:53 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP43be66d8b9e7: Fix 'Not Done' button hover state on inline comments

Summary

This rule was missing.

Test Plan

Test a comment where "Not Done" was present. Hover over button, it doesn't change.

Diff Detail

Repository

rP Phabricator

Branch

inline-ui-3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5023
Build 5041: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 29306.Mar 28 2015, 5:42 PM

chad retitled this revision from to Fix 'Not Done' button hover state on inline comments.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 28 2015, 5:42 PM

epriestley accepted this revision.Mar 28 2015, 5:49 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 28 2015, 5:49 PM

Add .device-desktop for hover states

Closed by commit rP43be66d8b9e7: Fix 'Not Done' button hover state on inline comments (authored by chad, committed by chad). · Explain WhyMar 28 2015, 5:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

4 lines

webroot/

rsrc/

css/

application/

differential/

phui-inline-comment.css

10 lines

Diff 29307

View Options

resources/celerity/map.php