Page MenuHomePhabricator

Fix comment previews in Quicksand
ClosedPublic

Authored by epriestley on Mar 28 2015, 12:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 5:11 PM
Unknown Object (File)
Tue, Apr 30, 5:11 PM
Unknown Object (File)
Tue, Apr 30, 5:11 PM
Unknown Object (File)
Mon, Apr 29, 2:39 PM
Unknown Object (File)
Mon, Apr 29, 2:27 PM
Unknown Object (File)
Wed, Apr 24, 10:42 PM
Unknown Object (File)
Thu, Apr 11, 7:37 AM
Unknown Object (File)
Tue, Apr 9, 1:13 PM
Subscribers

Details

Summary

Fixes T7063. Fixes T7059. We were running some extra unnecessary behaviors. In particular, we would render the menu but not actually send it over the wire, so some behaviors would execute, fail to find the nodes they expected, and throw. This cascaded into some other failures.

Do less work and don't activate behaviors which won't be able to run.

Test Plan

Clicked around, no more errors on page transition. Comment previews work.

Diff Detail

Repository
rP Phabricator
Branch
quick1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5017
Build 5035: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix comment previews in Quicksand.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad added a reviewer: chad.
This revision is now accepted and ready to land.Mar 28 2015, 1:53 PM
This revision was automatically updated to reflect the committed changes.