Page MenuHomePhabricator
Differential D12187

Polish up Done Button UI States
ClosedPublic
Actions

Authored by chad on Mar 28 2015, 1:02 AM.
Tags
None
Referenced Files
F15534246: D12187.id29295.diff
Wed, Apr 23, 11:31 PM
F15516316: D12187.id29295.diff
Fri, Apr 18, 6:00 PM
F15468028: D12187.diff
Thu, Apr 3, 7:31 PM
F15423290: D12187.id.diff
Mar 22 2025, 2:31 PM
F15387653: D12187.id29294.diff
Mar 15 2025, 2:44 AM
F15369594: D12187.diff
Mar 12 2025, 7:22 AM
F15333568: D12187.id29294.diff
Mar 8 2025, 3:07 AM
F15333002: D12187.id29295.diff
Mar 7 2025, 11:02 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP637974a1903b: Polish up Done Button UI States
Summary

Improves the UI quite a bit.

  • dashed borders everywhere to denote Unsubmitted
  • $sky sprinkled everywhere to denote Done
  • Consilidate inline-state-is-draft to simply styles.
Test Plan

Sent myself test comments, logged out, read comments on new account. Marked as done, submitted.

pasted_file (151×631 px, 16 KB)

pasted_file (141×648 px, 21 KB)

pasted_file (115×640 px, 13 KB)

pasted_file (128×643 px, 21 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 29294.Mar 28 2015, 1:02 AM
chad retitled this revision from to Polish up Done Button UI States.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 28 2015, 1:02 AM
chad updated this object.Mar 28 2015, 1:02 AM
chad edited the test plan for this revision. (Show Details)Mar 28 2015, 1:06 AM

This is really feeling pretty good.

epriestley accepted this revision.Mar 28 2015, 1:28 AM
epriestley edited edge metadata.

Putting dashes on the whole thing feels like it might be too heavy to me, and signifying "unsubmitted comment" and "unsubmitted checkmark" in similar ways might be a little confusing, but let's see how it works in practice.

This revision is now accepted and ready to land.Mar 28 2015, 1:28 AM
Closed by commit rP637974a1903b: Polish up Done Button UI States (authored by chad, committed by chad). · Explain WhyMar 28 2015, 1:30 AM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Mar 28 2015, 1:44 AM

itsbeautiful

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
infrastructure/
diff/
view/
55 lines
webroot/
rsrc/
css/
application/
differential/
104 lines

Diff 29295

View Options

resources/celerity/map.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Loading...
View Options

webroot/rsrc/css/application/differential/phui-inline-comment.css

Loading...
Phabricator · Built by Phacility