Improves the UI quite a bit.
- dashed borders everywhere to denote Unsubmitted
- $sky sprinkled everywhere to denote Done
- Consilidate inline-state-is-draft to simply styles.
Details
Details
- Reviewers
epriestley btrahan - Commits
- Restricted Diffusion Commit
rP637974a1903b: Polish up Done Button UI States
Sent myself test comments, logged out, read comments on new account. Marked as done, submitted.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Putting dashes on the whole thing feels like it might be too heavy to me, and signifying "unsubmitted comment" and "unsubmitted checkmark" in similar ways might be a little confusing, but let's see how it works in practice.