mmmmm dashed

oh no, it's the evil notchad

Should marking "done" state show in comment previews? It doesn't currently.

It shouldn't be possible to mark "Done" on inline comments which are showing in the inline preview, unless I'm misunderstanding?

There's no preview for the "epriestley marked 17 inlines done." transaction, just because the way that preview is built hasn't been fully modernized. It will show up eventually.

Inlines which you've altered by merely marking "Done" also don't show up in the inline preview. I think this is desirable/correct, at least for now, maybe? Feels kind of heavy/awkward to mix inlines you've added and inlines you've marked "Done" down there. I would expect "epriestley marked 17 inlines done." to show up there eventually, and probably for there to be other queues depending on other views of done-ness.

Generally, my expectation is:

• We should show "epriestley marked 17 inlines done." as a transaction preview, and don't only because the code isn't fully modern. This will either autofix eventually or I can explicitly fix it sooner.
• Adding the actual comments down there feels kind of heavy/weird offhand, but there's no technical reason we can't pursue it if it feels like it's missing. I'd want to get the transaction preview working first and see if that's good enough, though, and have a clearer idea of where we're going with the top of the revision.

other queues

other cues

Yeah, it just confused me at first. We say "unsubmitted", so you'll scroll down ... but it's not attached to the preview.

(and I get a dialog when I submit)