Page MenuHomePhabricator
Differential D12185

Provide getObjectOwnerPHID() on inline comment views
ClosedPublic
Actions

Authored by epriestley on Mar 27 2015, 6:20 PM.
Tags
None
Referenced Files
F14356859: D12185.diff
Fri, Dec 20, 1:07 AM
Unknown Object (File)
Thu, Dec 19, 12:50 AM
Unknown Object (File)
Thu, Dec 5, 9:18 AM
Unknown Object (File)
Wed, Nov 27, 10:27 AM
Unknown Object (File)
Nov 19 2024, 1:02 PM
Unknown Object (File)
Oct 23 2024, 11:51 PM
Unknown Object (File)
Oct 22 2024, 7:50 PM
Unknown Object (File)
Oct 14 2024, 12:58 AM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP174cf8239802: Provide getObjectOwnerPHID() on inline comment views
Summary

This returns the PHID of the current revision owner, or the commit author, if one exists.

NOTE: For drafts, we currently return null; I'll fix that in a future change. Should be correct for submitted comments.
Test Plan

Added an inline, nothing seemed broken.

Diff Detail

Repository
rP Phabricator
Branch
authority
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/diff/PhabricatorInlineCommentController.php:310XHP16TODO Comment
Advicesrc/infrastructure/diff/PhabricatorInlineCommentPreviewController.php:29XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 5011
Build 5029: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29286.Mar 27 2015, 6:20 PM
epriestley retitled this revision from to Provide getObjectOwnerPHID() on inline comment views.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 27 2015, 6:20 PM
chad accepted this revision.Mar 27 2015, 6:22 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 27 2015, 6:22 PM
Closed by commit rP174cf8239802: Provide getObjectOwnerPHID() on inline comment views (authored by epriestley, committed by epriestley). · Explain WhyMar 27 2015, 6:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 29286

View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

Loading...
View Options

src/applications/differential/parser/DifferentialChangesetParser.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetHTMLRenderer.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetRenderer.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionDiffController.php

Loading...
View Options

src/infrastructure/diff/PhabricatorInlineCommentController.php

Loading...
View Options

src/infrastructure/diff/PhabricatorInlineCommentPreviewController.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Loading...
Phabricator · Built by Phacility