Page MenuHomePhabricator
Differential D12181

Conpherence - fix bug with possible null value
ClosedPublic
Actions

Authored by btrahan on Mar 27 2015, 1:31 PM.
Tags
None
Referenced Files
F14087406: D12181.diff
Sat, Nov 23, 9:31 PM
Unknown Object (File)
Mon, Nov 18, 8:37 AM
Unknown Object (File)
Thu, Nov 14, 8:43 PM
Unknown Object (File)
Sat, Nov 9, 4:24 PM
Unknown Object (File)
Tue, Nov 5, 11:43 PM
Unknown Object (File)
Thu, Oct 31, 10:47 AM
Unknown Object (File)
Sun, Oct 27, 5:20 AM
Unknown Object (File)
Sat, Oct 26, 1:52 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T7675: Conpherence functionality in full view got blocked due to "room" stuff
Commits
Restricted Diffusion Commit
rPa428bb8ad4ec: Conpherence - fix bug with possible null value
Summary

Fixes T7675. epriestley caught this in code review and I didn't implement it all the way

Test Plan

logicypoo

Diff Detail

Repository
rP Phabricator
Branch
bug
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5005
Build 5023: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 29277.Mar 27 2015, 1:31 PM
btrahan retitled this revision from to Conpherence - fix bug with possible null value.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
btrahan added a task: T7675: Conpherence functionality in full view got blocked due to "room" stuff.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 27 2015, 1:31 PM
Closed by commit rPa428bb8ad4ec: Conpherence - fix bug with possible null value (authored by btrahan, committed by btrahan). · Explain WhyMar 27 2015, 1:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
conpherence/
view/
2 lines

Diff 29277

View Options

src/applications/conpherence/view/ConpherenceThreadListView.php

Loading...
Phabricator · Built by Phacility