Page MenuHomePhabricator
Differential D12181

Conpherence - fix bug with possible null value
ClosedPublic
Actions

Authored by btrahan on Mar 27 2015, 1:31 PM.
Tags
None
Referenced Files
F18777889: D12181.diff
Sat, Oct 11, 6:15 AM
F18742503: D12181.diff
Thu, Oct 2, 7:49 PM
F18630775: D12181.id29278.diff
Sep 16 2025, 12:54 PM
F18628447: D12181.diff
Sep 16 2025, 6:21 AM
F18620456: D12181.id29278.diff
Sep 15 2025, 5:17 AM
F18600402: D12181.diff
Sep 13 2025, 9:40 AM
F18196256: D12181.id29278.diff
Aug 17 2025, 5:21 PM
F18098736: D12181.id29277.diff
Aug 8 2025, 11:01 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T7675: Conpherence functionality in full view got blocked due to "room" stuff
Commits
Restricted Diffusion Commit
rPa428bb8ad4ec: Conpherence - fix bug with possible null value
Summary

Fixes T7675. epriestley caught this in code review and I didn't implement it all the way

Test Plan

logicypoo

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 29277.Mar 27 2015, 1:31 PM
btrahan retitled this revision from to Conpherence - fix bug with possible null value.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
btrahan added a task: T7675: Conpherence functionality in full view got blocked due to "room" stuff.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 27 2015, 1:31 PM
Closed by commit rPa428bb8ad4ec: Conpherence - fix bug with possible null value (authored by btrahan, committed by btrahan). · Explain WhyMar 27 2015, 1:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
conpherence/
view/
2 lines

Diff 29278

View Options

src/applications/conpherence/view/ConpherenceThreadListView.php

Loading...
Phabricator · Built by Phacility