Page MenuHomePhabricator
Differential D12162

More SIMPLE button styles for buttons and button bars
ClosedPublic
Actions

Authored by chad on Mar 25 2015, 7:48 PM.
Tags
None
Referenced Files
F14061026: D12162.diff
Mon, Nov 18, 4:46 AM
F14053666: D12162.diff
Fri, Nov 15, 6:06 PM
F14043443: D12162.diff
Tue, Nov 12, 10:13 AM
F14026285: D12162.diff
Fri, Nov 8, 12:51 AM
F13994626: D12162.diff
Wed, Oct 23, 7:26 AM
F13992255: D12162.id.diff
Tue, Oct 22, 3:28 PM
F13979156: D12162.id29235.diff
Oct 19 2024, 2:56 AM
F13955520: D12162.id29234.diff
Oct 14 2024, 1:47 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T1460: Add "Done" link to an inline comment
Commits
Restricted Diffusion Commit
rP47114513b00f: More SIMPLE button styles for buttons and button bars
Summary

Ref T1460, this adds additional buttons colors and styles for use in inline comments. Will also backport to Calendar and PHUIInfoView

Test Plan

Review new buttons and hover states in UI Examples.

Screen_Shot_2015-03-25_at_12.47.57_PM.png (586×920 px, 39 KB)

Screen_Shot_2015-03-25_at_12.48.11_PM.png (742×1 px, 143 KB)

Diff Detail

Repository
rP Phabricator
Branch
buttonz
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4981
Build 4999: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 29234.Mar 25 2015, 7:48 PM
chad retitled this revision from to More SIMPLE button styles for buttons and button bars.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 25 2015, 7:48 PM
chad edited the test plan for this revision. (Show Details)Mar 25 2015, 7:48 PM
chad updated this object.
chad added a task: T1460: Add "Done" link to an inline comment.
epriestley accepted this revision.Mar 25 2015, 7:50 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 25 2015, 7:50 PM
Closed by commit rP47114513b00f: More SIMPLE button styles for buttons and button bars (authored by chad, committed by chad). · Explain WhyMar 25 2015, 7:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
uiexample/
examples/
48 lines
49 lines
view/
phui/
4 lines
webroot/
rsrc/
css/
phui/
73 lines

Diff 29234

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/uiexample/examples/PHUIButtonBarExample.php

Loading...
View Options

src/applications/uiexample/examples/PHUIButtonExample.php

Loading...
View Options

src/view/phui/PHUIButtonView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-button.css

Loading...
Phabricator · Built by Phacility