Conpherence - Implement edit rules for rooms
ClosedPublic
Actions

Authored by btrahan on Mar 25 2015, 6:25 PM.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T7586: Implement edit rules for rooms

Commits

Restricted Diffusion Commit
rP42a0229a52a4: Conpherence - Implement edit rules for rooms

Summary

Fixes T7586. If you can't edit a room, the pertinent UI is greyed out. One exception is the title of the room in the full viewer; this crumb is not disabled as it would be hard to read. Otherwise though, everything is disabled nicely.

Test Plan

tried to add participants when I wasn't allowed to and got an error. added participants otherwise okay. tried to edit title when i wasn't allowed and got an error. otherwise okay. left conpherence threads / rooms successfully.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 29231.Mar 25 2015, 6:25 PM

btrahan added a task: T7586: Implement edit rules for rooms.

btrahan retitled this revision from to Conpherence - Implement edit rules for rooms.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added a reviewer: chad. · View Herald TranscriptMar 25 2015, 6:25 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

I guess I should be doing the requiresCapabilities stuff in the ConpherenceThreadEditor too

I guess I should be doing the requiresCapabilities stuff in the ConpherenceThreadEditor too

Yeah, this would be good for completeness. We should ideally probably default everything to require CAN_EDIT, but that would be a lot of work / hard to test.

Everything else looks great.

This revision is now accepted and ready to land.Mar 25 2015, 6:30 PM