Page MenuHomePhabricator
Differential D12144

Provide better parsing primitives for hunks
ClosedPublic
Actions

Authored by epriestley on Mar 24 2015, 5:54 PM.
Tags
None
Referenced Files
F15538138: D12144.diff
Thu, Apr 24, 5:32 PM
F15483779: D12144.id29193.diff
Wed, Apr 9, 2:21 PM
F15457302: D12144.id29203.diff
Sun, Mar 30, 3:30 PM
F15403460: D12144.diff
Mar 18 2025, 3:28 AM
F15398145: D12144.id29193.diff
Mar 16 2025, 11:26 PM
F15384639: D12144.diff
Mar 14 2025, 8:28 PM
F15381990: D12144.id.diff
Mar 14 2025, 10:15 AM
F15338766: D12144.diff
Mar 9 2025, 12:45 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP74a4c2cf0b1b: Provide better parsing primitives for hunks
Summary

Ref T1266. This prepares to fix case (2) on T1266 by improving the robustness of hunk parsing.

In particular, the copy detection code abuses this API because it isn't currently expressive or flexible enough.

Make it more flexible and cover it exhaustively.

I'll move callsites to the new stuff in upcoming revisions.

Test Plan

Unit tests.

Diff Detail

Repository
rP Phabricator
Branch
movecode1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/storage/DifferentialHunk.php:119XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 4960
Build 4978: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29193.Mar 24 2015, 5:54 PM
epriestley retitled this revision from to Provide better parsing primitives for hunks.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: Restricted Maniphest Task.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 24 2015, 5:54 PM
epriestley mentioned this in D12145: Clean up copy detection code a bit.Mar 24 2015, 6:25 PM
btrahan accepted this revision.Mar 24 2015, 6:33 PM
btrahan edited edge metadata.

Yay unit tests!

This revision is now accepted and ready to land.Mar 24 2015, 6:33 PM
Closed by commit rP74a4c2cf0b1b: Provide better parsing primitives for hunks (authored by epriestley, committed by epriestley). · Explain WhyMar 24 2015, 8:11 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in rP373aaa643a51: Clean up copy detection code a bit.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
storage/
113 lines
__tests__/
316 lines
hunk/
9 lines
9 lines
16 lines
10 lines
10 lines
10 lines

Diff 29193

View Options

src/applications/differential/storage/DifferentialHunk.php

Loading...
View Options

src/applications/differential/storage/__tests__/DifferentialHunkTestCase.php

Loading...
View Options

src/applications/differential/storage/__tests__/hunk/fruit1.diff

Loading...
View Options

src/applications/differential/storage/__tests__/hunk/fruit2.diff

Loading...
View Options

src/applications/differential/storage/__tests__/hunk/offset.diff

Loading...
View Options

src/applications/differential/storage/__tests__/hunk/trailing_newline_absent.diff

Loading...
View Options

src/applications/differential/storage/__tests__/hunk/trailing_newline_added.diff

Loading...
View Options

src/applications/differential/storage/__tests__/hunk/trailing_newline_removed.diff

Loading...
Phabricator · Built by Phacility