Page MenuHomePhabricator

Provide better parsing primitives for hunks
ClosedPublic

Authored by epriestley on Mar 24 2015, 5:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 10, 7:29 PM
Unknown Object (File)
Feb 14 2024, 1:26 AM
Unknown Object (File)
Feb 10 2024, 7:29 AM
Unknown Object (File)
Jan 29 2024, 8:55 AM
Unknown Object (File)
Dec 22 2023, 7:22 PM
Unknown Object (File)
Dec 14 2023, 3:12 PM
Unknown Object (File)
Dec 9 2023, 2:01 AM
Unknown Object (File)
Dec 3 2023, 6:31 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP74a4c2cf0b1b: Provide better parsing primitives for hunks
Summary

Ref T1266. This prepares to fix case (2) on T1266 by improving the robustness of hunk parsing.

In particular, the copy detection code abuses this API because it isn't currently expressive or flexible enough.

Make it more flexible and cover it exhaustively.

I'll move callsites to the new stuff in upcoming revisions.

Test Plan

Unit tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Provide better parsing primitives for hunks.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: Restricted Maniphest Task.
btrahan edited edge metadata.

Yay unit tests!

This revision is now accepted and ready to land.Mar 24 2015, 6:33 PM
This revision was automatically updated to reflect the committed changes.