Page MenuHomePhabricator

T7651: Created herald.queryrules Conduit API method.
Needs RevisionPublic

Authored by Pawka on Mar 24 2015, 9:31 AM.
Referenced Files
Unknown Object (File)
Tue, Apr 2, 6:59 AM
Unknown Object (File)
Mon, Apr 1, 9:55 AM
Unknown Object (File)
Tue, Mar 26, 9:26 AM
Unknown Object (File)
Sat, Mar 23, 4:42 PM
Unknown Object (File)
Mar 16 2024, 6:23 AM
Unknown Object (File)
Feb 29 2024, 10:37 PM
Unknown Object (File)
Feb 21 2024, 3:53 AM
Unknown Object (File)
Feb 13 2024, 12:17 AM



Created herald.queryrules Conduit API method to search Herald rules.

Test Plan

Open and perform search with different parameters.

Diff Detail

rP Phabricator
Lint Passed
Tests Passed
Build Status
Buildable 4955
Build 4973: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

Pawka retitled this revision from to T7651: Created herald.queryrules Conduit API method..
Pawka updated this object.
Pawka edited the test plan for this revision. (Show Details)
Pawka added a reviewer: epriestley.
Pawka edited edge metadata.
protected function buildConditionsInfoDictionaries(array $conditions) {
  assert_instances_of($conditions, 'HeraldCondition');

  $result = array();

  if (!empty($conditions)) {
    foreach ($conditions as $cond) {
      $result[$cond->getID()] = array(
        'id'             => $cond->getID(),
        'fieldName'      => $cond->getFieldName(),
        'fieldCondition' => $cond->getFieldCondition(),
        'value'          => $cond->getValue(),

  return $result;

protected function buildActionsInfoDictionaries(array $actions) {
  assert_instances_of($actions, 'HeraldAction');

  $result = array();

  if (!empty($actions)) {
    foreach ($actions as $action) {
      $result[$action->getID()] = array(
        'id'     => $action->getID(),
        'action' => $action->getAction(),
        'target' => $action->getTarget(),

  return $result;


epriestley edited edge metadata.

Per T7651, I don't want to bring this upstream now. Particularly, it should wait for T7715 and rebuild on top of that, and it seems questionable even then.

This revision now requires changes to proceed.May 19 2015, 3:20 PM