Page MenuHomePhabricator
Differential D12122

Allow repositories to be ordered by commit count
ClosedPublic
Actions

Authored by epriestley on Mar 21 2015, 11:28 AM.
Tags
None
Referenced Files
F14836810: D12122.diff
Fri, Jan 31, 4:57 AM
Unknown Object (File)
Wed, Jan 29, 7:32 PM
Unknown Object (File)
Fri, Jan 24, 10:56 PM
Unknown Object (File)
Fri, Jan 24, 1:33 AM
Unknown Object (File)
Fri, Jan 24, 1:33 AM
Unknown Object (File)
Fri, Jan 24, 1:33 AM
Unknown Object (File)
Fri, Jan 24, 1:33 AM
Unknown Object (File)
Tue, Jan 21, 9:22 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7640: Add "number of commits" as order by option in search
Commits
Restricted Diffusion Commit
rP6eadfe6a6fce: Allow repositories to be ordered by commit count
Summary

Fixes T7640.

Test Plan

Screen_Shot_2015-03-21_at_3.59.31_AM.png (756×339 px, 65 KB)

Diff Detail

Repository
rP Phabricator
Branch
reposize1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4936
Build 4954: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29148.Mar 21 2015, 11:28 AM
epriestley retitled this revision from to Allow repositories to be ordered by commit count.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7640: Add "number of commits" as order by option in search.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 21 2015, 11:28 AM
epriestley added inline comments.Mar 21 2015, 11:28 AM
src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php
287–289

Per recent fixes to Maniphest, this lays some groundwork for doing ORDER BY clauses in a more consistent/general way.

btrahan accepted this revision.Mar 23 2015, 3:57 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 23 2015, 3:57 PM
Closed by commit rP6eadfe6a6fce: Allow repositories to be ordered by commit count (authored by epriestley, committed by epriestley). · Explain WhyMar 23 2015, 4:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
query/
63 lines
2 lines
infrastructure/
query/
policy/
38 lines

Diff 29148

View Options

src/applications/repository/query/PhabricatorRepositoryQuery.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositorySearchEngine.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility