Paths

Table of Contentst

Differential D12115

Basic touchups to Phortune UI
ClosedPublic
Actions

Authored by chad on Mar 20 2015, 6:52 PM.

Tags

None

Referenced Files

	F14028007: D12115.diff
	Fri, Nov 8, 11:17 AM

	F14017780: D12115.diff
	Mon, Nov 4, 10:47 PM

	F13990149: D12115.id29138.diff
	Tue, Oct 22, 1:38 AM

	Unknown Object (File)
	Sep 20 2024, 9:47 AM

	Unknown Object (File)
	Sep 20 2024, 7:31 AM

	Unknown Object (File)
	Aug 28 2024, 4:57 AM

	Unknown Object (File)
	Aug 22 2024, 4:54 PM

	Unknown Object (File)
	Aug 17 2024, 5:02 PM

Subscribers

Details

Reviewers

epriestley
btrahan

Commits

Restricted Diffusion Commit
rPc4799b2c4535: Basic touchups to Phortune UI

Summary

This is just a quick pass to fix a few bugs and spacing issues, Phortune itself could probably use some more custom UI, but that'll require some thought and abstraction. This also adds a new taller table CSS, which I mayyyy make automatic on tables with few rows, we'll see.

Test Plan

Browsed my Phortune account, tested new spacing on admin for 'full effect'

Diff Detail

Repository

Branch

phortune

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4928
Build 4946: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 29138.Mar 20 2015, 6:52 PM

chad retitled this revision from to Basic touchups to Phortune UI.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 20 2015, 6:52 PM

These tweaks all seem reasonable to me. Thanks!

This revision is now accepted and ready to land.Mar 23 2015, 5:35 PM

Closed by commit rPc4799b2c4535: Basic touchups to Phortune UI (authored by chad, committed by chad). · Explain WhyMar 26 2015, 8:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

6 lines

src/

applications/

phortune/

controller/

PhortuneAccountListController.php

5 lines

PhortuneMerchantViewController.php

1 line

view/

PhortuneChargeTableView.php

1 line

PhortuneOrderTableView.php

1 line

PhortuneSubscriptionTableView.php

1 line

view/

control/

AphrontTableView.php

22 lines

webroot/

rsrc/

css/

aphront/

9 lines

Diff 29138

resources/celerity/map.php

Loading...

src/applications/phortune/controller/PhortuneAccountListController.php

Loading...

src/applications/phortune/controller/PhortuneMerchantViewController.php

Loading...

src/applications/phortune/view/PhortuneChargeTableView.php

Loading...

src/applications/phortune/view/PhortuneOrderTableView.php

Loading...

src/applications/phortune/view/PhortuneSubscriptionTableView.php

Loading...

src/view/control/AphrontTableView.php

Loading...

webroot/rsrc/css/aphront/table-view.css

Loading...