Page MenuHomePhabricator

Fix chunk upload fallback behavior
ClosedPublic

Authored by epriestley on Mar 18 2015, 11:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 4:18 PM
Unknown Object (File)
Tue, Dec 17, 9:33 PM
Unknown Object (File)
Fri, Dec 13, 2:44 AM
Unknown Object (File)
Thu, Dec 12, 5:27 PM
Unknown Object (File)
Wed, Dec 4, 2:49 PM
Unknown Object (File)
Wed, Nov 27, 11:22 PM
Unknown Object (File)
Nov 22 2024, 8:08 AM
Unknown Object (File)
Nov 18 2024, 5:46 AM

Details

Summary

Ref T7594. Currently, if a chunk upload fails, we incorrectly swallow the failure and fall back to single-file upload, which will often fail by hitting size limits. This also silences the original error.

Instead, do chunk uploads outside the block so that any exceptions escape, and we don't try to fall back to single-file upload.

Mostly just trying to get more info about what's going wrong on @joshuaspence's install.

Test Plan

Faked an exception in chunk upload, ran arc upload on a big file, saw the exception displayed on the console.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix chunk upload fallback behavior.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a subscriber: joshuaspence.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 19 2015, 12:32 AM
This revision was automatically updated to reflect the committed changes.