Page MenuHomePhabricator

Make file upload policies more consistent
ClosedPublic

Authored by epriestley on Mar 17 2015, 12:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 14, 2:30 PM
Unknown Object (File)
Fri, Apr 5, 3:50 AM
Unknown Object (File)
Mon, Apr 1, 7:35 PM
Unknown Object (File)
Mon, Apr 1, 8:55 AM
Unknown Object (File)
Thu, Mar 28, 6:31 PM
Unknown Object (File)
Sun, Mar 24, 8:00 AM
Unknown Object (File)
Thu, Mar 21, 12:15 AM
Unknown Object (File)
Feb 3 2024, 2:34 AM
Subscribers

Details

Summary

Ref T7149. Currently, global drag and drop always uses the most open visibility policy on the install. This was appropriate before the application preference was introduced, but default to the application preference now.

In particular, this supports a default value of "Administrators" in the Phacility cluster.

Also simplify/clean up some code.

Test Plan
  • Set application default policy to "Adminstrators".
  • Uploaded file via drag-and-drop, saw "administrators" policy.
  • Uploaded file via arc upload, saw "administrators" policy.
    • Saw better URI for a text file upload after patch.
  • Uploaded file via drag-and-drop-to-textarea, saw "only viewer" policy.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make file upload policies more consistent.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 17 2015, 1:51 AM
This revision was automatically updated to reflect the committed changes.