Page MenuHomePhabricator

Improve chat column behavior for newline in empty text box
ClosedPublic

Authored by epriestley on Mar 16 2015, 12:09 PM.
Tags
None
Referenced Files
F17750373: D12089.diff
Tue, Jul 22, 3:23 AM
Unknown Object (File)
May 9 2025, 2:05 PM
Unknown Object (File)
Apr 21 2025, 9:12 AM
Unknown Object (File)
Apr 18 2025, 2:02 PM
Unknown Object (File)
Apr 18 2025, 4:40 AM
Unknown Object (File)
Apr 4 2025, 3:06 AM
Unknown Object (File)
Mar 30 2025, 2:28 PM
Unknown Object (File)
Mar 21 2025, 11:34 PM
Subscribers

Details

Summary

Ref T7538. I got this half correct but not fully correct: when you press enter in an empty text box, do nothing (instead of: sending an empty message, or writing a literal newline).

Test Plan

Hit enter in empty chat column box.

Diff Detail

Repository
rP Phabricator
Branch
chat1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4896
Build 4914: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Improve chat column behavior for newline in empty text box.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 16 2015, 1:42 PM
This revision was automatically updated to reflect the committed changes.