Differential D12089

Improve chat column behavior for newline in empty text box
ClosedPublic
Actions

Authored by epriestley on Mar 16 2015, 12:09 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T7538: Consider refinements to Conpherence send-on-enter interaction

Commits

Restricted Diffusion Commit
rPcf54194ef56c: Improve chat column behavior for newline in empty text box

Summary

Ref T7538. I got this half correct but not fully correct: when you press enter in an empty text box, do nothing (instead of: sending an empty message, or writing a literal newline).

Test Plan

Hit enter in empty chat column box.

Diff Detail

Repository

rP Phabricator

Branch

chat1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4896
Build 4914: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29084.Mar 16 2015, 12:09 PM

epriestley retitled this revision from to Improve chat column behavior for newline in empty text box.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T7538: Consider refinements to Conpherence send-on-enter interaction.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 16 2015, 12:09 PM

chad accepted this revision.Mar 16 2015, 1:42 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 16 2015, 1:42 PM

Closed by commit rPcf54194ef56c: Improve chat column behavior for newline in empty text box (authored by epriestley, committed by epriestley). · Explain WhyMar 16 2015, 1:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

24 lines

webroot/

rsrc/

js/

application/

conpherence/

behavior-durable-column.js

4 lines

Diff 29084

View Options

resources/celerity/map.php