Differential D12085

Send on enter in Conpherence chat column
ClosedPublic
Actions

Authored by epriestley on Mar 14 2015, 6:09 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T7538: Consider refinements to Conpherence send-on-enter interaction

Commits

Restricted Diffusion Commit
rPe6f1c34a47ef: Send on enter in Conpherence chat column

Summary

Ref T7538. We can figure out whether to backport this to main Conpherence later and/or remove buttons, etc., but this behavior seems pretty clearly good.

Test Plan

Pressed enter (sent message).
Pressed shift+enter (newline).

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29068.Mar 14 2015, 6:09 PM

epriestley retitled this revision from to Send on enter in Conpherence chat column.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T7538: Consider refinements to Conpherence send-on-enter interaction.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 14 2015, 6:09 PM

chad accepted this revision.Mar 14 2015, 6:16 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 14 2015, 6:16 PM

Closed by commit rPe6f1c34a47ef: Send on enter in Conpherence chat column (authored by epriestley, committed by epriestley). · Explain WhyMar 14 2015, 6:16 PM

This revision was automatically updated to reflect the committed changes.

chad mentioned this in T11623: Make Conpherence send text with bare return key, like a chatroom.Sep 22 2016, 10:00 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

30 lines

webroot/

rsrc/

js/

application/

conpherence/

behavior-durable-column.js

15 lines

Diff 29069

View Options

resources/celerity/map.php