Page MenuHomePhabricator
Differential D12084

Fix durable column content falling off the page
ClosedPublic
Actions

Authored by epriestley on Mar 14 2015, 5:55 PM.
Tags
None
Referenced Files
F15484301: D12084.id29067.diff
Wed, Apr 9, 5:31 PM
F15481467: D12084.id.diff
Tue, Apr 8, 8:57 PM
F15481268: D12084.id.diff
Tue, Apr 8, 7:34 PM
F15479924: D12084.id29066.diff
Tue, Apr 8, 10:16 AM
F15478255: D12084.diff
Mon, Apr 7, 9:38 PM
F15471250: D12084.id29067.diff
Sat, Apr 5, 4:14 AM
F15467523: D12084.diff
Thu, Apr 3, 3:50 PM
F15457966: D12084.diff
Sun, Mar 30, 8:17 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T7529: Durable Column scrollbars be runnin wild (desktop)
Commits
Restricted Diffusion Commit
rP8414c0ab3efe: Fix durable column content falling off the page
Summary

Fixes T7529. I think stylesheet order got juggled at some point and made this more specific, but we don't actually need it.

Test Plan
  • Column now looks reasonable.
  • Everything else does too.

Diff Detail

Repository
rP Phabricator
Branch
colcss
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4890
Build 4908: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29066.Mar 14 2015, 5:55 PM
epriestley retitled this revision from to Fix durable column content falling off the page.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
epriestley added a task: T7529: Durable Column scrollbars be runnin wild (desktop).
Herald added a subscriber: epriestley. · View Herald TranscriptMar 14 2015, 5:55 PM
chad accepted this revision.Mar 14 2015, 5:57 PM
chad edited edge metadata.

Awesome, good find. I thought it was CSS but hadn't quite narrowed it down.

This revision is now accepted and ready to land.Mar 14 2015, 5:57 PM
Closed by commit rP8414c0ab3efe: Fix durable column content falling off the page (authored by epriestley, committed by epriestley). · Explain WhyMar 14 2015, 5:58 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Mar 14 2015, 5:59 PM

It's possible this did something important, but the usual suspects all look fine for me locally (Conpherence, Workboards, small pages, big pages, pages with no column).

chad added a comment.Mar 14 2015, 6:02 PM

Also there is a position: relative and position: absolute on that column in durable-column.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
webroot/
rsrc/
css/
application/
base/
1 line

Diff 29066

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/application/base/standard-page-view.css

Loading...
Phabricator · Built by Phacility