Differential D12084

Fix durable column content falling off the page
ClosedPublic
Actions

Authored by epriestley on Mar 14 2015, 5:55 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T7529: Durable Column scrollbars be runnin wild (desktop)

Commits

Restricted Diffusion Commit
rP8414c0ab3efe: Fix durable column content falling off the page

Summary

Fixes T7529. I think stylesheet order got juggled at some point and made this more specific, but we don't actually need it.

Test Plan

Column now looks reasonable.
Everything else does too.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29066.Mar 14 2015, 5:55 PM

epriestley retitled this revision from to Fix durable column content falling off the page.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T7529: Durable Column scrollbars be runnin wild (desktop).

Herald added a subscriber: epriestley. · View Herald TranscriptMar 14 2015, 5:55 PM

Awesome, good find. I thought it was CSS but hadn't quite narrowed it down.

This revision is now accepted and ready to land.Mar 14 2015, 5:57 PM

Closed by commit rP8414c0ab3efe: Fix durable column content falling off the page (authored by epriestley, committed by epriestley). · Explain WhyMar 14 2015, 5:58 PM

This revision was automatically updated to reflect the committed changes.

It's possible this did something important, but the usual suspects all look fine for me locally (Conpherence, Workboards, small pages, big pages, pages with no column).

Also there is a position: relative and position: absolute on that column in durable-column.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

10 lines

webroot/

rsrc/

css/

application/

base/

standard-page-view.css

1 line

Diff 29067

View Options

resources/celerity/map.php