Differential D12042

Conpherence - add support for users with no conpherences in durable column view
ClosedPublic
Actions

Authored by btrahan on Mar 11 2015, 6:48 PM.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T7014: Annouce Persistent Chat option in Conpherence

Commits

Restricted Diffusion Commit
rP116f4625b6ca: Conpherence - add support for users with no conpherences in durable column view

Summary

Ref T7014. This just makes it so there's almost no UI and a simple "You have no messages. <button>Send a message.</button>" UI

Test Plan

hacked the code such that should_404 and conpherence were false and null respectively. verified i got the right ui in the durable column. verified send a message button worked, ending up with me in main conpherence view on the right message

Diff Detail

Repository

rP Phabricator

Branch

T7014_4

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4840
Build 4856: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 28984.Mar 11 2015, 6:48 PM

btrahan added a task: T7014: Annouce Persistent Chat option in Conpherence.

btrahan retitled this revision from to Conpherence - add support for users with no conpherences in durable column view.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 11 2015, 6:48 PM

epriestley accepted this revision.Mar 11 2015, 6:49 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 11 2015, 6:49 PM

Closed by commit rP116f4625b6ca: Conpherence - add support for users with no conpherences in durable column view (authored by btrahan, committed by btrahan). · Explain WhyMar 11 2015, 6:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

controller/

ConpherenceColumnViewController.php

49 lines

view/

ConpherenceDurableColumnView.php

34 lines

Diff 28984

View Options

src/applications/conpherence/controller/ConpherenceColumnViewController.php