Page MenuHomePhabricator
Differential D12042

Conpherence - add support for users with no conpherences in durable column view
ClosedPublic
Actions

Authored by btrahan on Mar 11 2015, 6:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 5:21 AM
Unknown Object (File)
Tue, Apr 30, 4:51 PM
Unknown Object (File)
Tue, Apr 30, 4:50 PM
Unknown Object (File)
Tue, Apr 30, 4:50 PM
Unknown Object (File)
Mon, Apr 29, 2:18 PM
Unknown Object (File)
Thu, Apr 25, 12:51 AM
Unknown Object (File)
Mon, Apr 22, 9:47 AM
Unknown Object (File)
Fri, Apr 12, 9:15 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Maniphest Tasks
T7014: Annouce Persistent Chat option in Conpherence
Commits
Restricted Diffusion Commit
rP116f4625b6ca: Conpherence - add support for users with no conpherences in durable column view
Summary

Ref T7014. This just makes it so there's almost no UI and a simple "You have no messages. <button>Send a message.</button>" UI

Test Plan

hacked the code such that should_404 and conpherence were false and null respectively. verified i got the right ui in the durable column. verified send a message button worked, ending up with me in main conpherence view on the right message

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 28984.Mar 11 2015, 6:48 PM
btrahan added a task: T7014: Annouce Persistent Chat option in Conpherence.
btrahan retitled this revision from to Conpherence - add support for users with no conpherences in durable column view.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 11 2015, 6:48 PM
epriestley accepted this revision.Mar 11 2015, 6:49 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 11 2015, 6:49 PM
Closed by commit rP116f4625b6ca: Conpherence - add support for users with no conpherences in durable column view (authored by btrahan, committed by btrahan). · Explain WhyMar 11 2015, 6:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
conpherence/
controller/
49 lines
view/
34 lines

Diff 28986

View Options

src/applications/conpherence/controller/ConpherenceColumnViewController.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceDurableColumnView.php

Loading...
Phabricator · Built by Phacility