Page MenuHomePhabricator
Differential D12036

Generalize URI pattern blacklist for Quicksand
ClosedPublic
Actions

Authored by epriestley on Mar 10 2015, 10:13 PM.
Tags
None
Referenced Files
F13222908: D12036.diff
Sun, May 19, 4:05 AM
F13213185: D12036.id28972.diff
Fri, May 17, 7:29 AM
F13179768: D12036.diff
Wed, May 8, 9:26 PM
Unknown Object (File)
Sat, May 4, 6:22 PM
Unknown Object (File)
Wed, Apr 24, 10:42 PM
Unknown Object (File)
Apr 9 2024, 7:45 PM
Unknown Object (File)
Apr 5 2024, 12:47 AM
Unknown Object (File)
Mar 30 2024, 12:15 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7060: Quicksand and Conpherence interact incorrectly
Commits
Restricted Diffusion Commit
rP6fa507987d71: Generalize URI pattern blacklist for Quicksand
Summary

Fixes T7060. Removes some hard-coding.

This assumes that "pages with no durable column" and "pages with no Quicksand" are the same, but that's correct today and I can't come up with a use case where they'd be different offhand.

Test Plan
  • Clicked a revision with column open, got Quicksand navigation.
  • Clicked into Conpherence with column open, got real navigation.

Diff Detail

Repository
rP Phabricator
Branch
qsand1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4832
Build 4848: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28972.Mar 10 2015, 10:13 PM
epriestley retitled this revision from to Generalize URI pattern blacklist for Quicksand.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7060: Quicksand and Conpherence interact incorrectly.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 10 2015, 10:13 PM
epriestley added inline comments.Mar 10 2015, 10:15 PM
src/applications/conpherence/view/ConpherenceLayoutView.php
82

This fixes a fatal when viewing /conpherence/ locally.

btrahan accepted this revision.Mar 10 2015, 10:31 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 10 2015, 10:31 PM
Closed by commit rP6fa507987d71: Generalize URI pattern blacklist for Quicksand (authored by epriestley, committed by epriestley). · Explain WhyMar 10 2015, 10:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
132 lines
src/
applications/
base/
4 lines
conpherence/
application/
6 lines
view/
4 lines
view/
page/
50 lines
webroot/
rsrc/
externals/
javelin/
lib/
52 lines
js/
application/
conpherence/
9 lines

Diff 28972

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/base/PhabricatorApplication.php

Loading...
View Options

src/applications/conpherence/application/PhabricatorConpherenceApplication.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceLayoutView.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
View Options

webroot/rsrc/externals/javelin/lib/Quicksand.js

Loading...
View Options

webroot/rsrc/js/application/conpherence/behavior-quicksand-blacklist.js

Loading...
Phabricator · Built by Phacility