Page MenuHomePhabricator

Write "hasReplies" to database for inline comments
ClosedPublic

Authored by epriestley on Mar 9 2015, 6:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 16, 8:09 PM
Unknown Object (File)
Tue, Apr 16, 8:09 PM
Unknown Object (File)
Tue, Apr 16, 7:46 PM
Unknown Object (File)
Tue, Apr 16, 7:21 PM
Unknown Object (File)
Tue, Apr 16, 6:23 PM
Unknown Object (File)
Thu, Apr 11, 8:20 AM
Unknown Object (File)
Mon, Apr 8, 12:53 AM
Unknown Object (File)
Mon, Apr 1, 3:08 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
T1460: Add "Done" link to an inline comment
Commits
Restricted Diffusion Commit
rP2972894a4df9: Write "hasReplies" to database for inline comments
Summary

Ref T1460. Ref T2618.

When publishing a draft inline, mark the inline it replies to (if any) as replied to.

Also, don't load deleted comments as drafts (sets the stage for T2618).

I'll make an effort to clean up the loading mess here in the next revision, and find some more appropriate home for the shared code.

Test Plan

Made and replied to comments in Differential and Diffusion. Saw comments get marked as "Has Replies" and "Is Reply".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Write "hasReplies" to database for inline comments.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T1460: Add "Done" link to an inline comment, Restricted Maniphest Task.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 9 2015, 8:36 PM
This revision was automatically updated to reflect the committed changes.