Page MenuHomePhabricator
Differential D12022

Show a more tailored message when adding empty files
ClosedPublic
Actions

Authored by epriestley on Mar 9 2015, 12:47 AM.
Tags
None
Referenced Files
F14102923: D12022.diff
Tue, Nov 26, 8:34 PM
Unknown Object (File)
Sat, Nov 23, 6:22 PM
Unknown Object (File)
Sat, Nov 23, 3:14 PM
Unknown Object (File)
Wed, Nov 20, 10:21 PM
Unknown Object (File)
Mon, Nov 18, 6:33 PM
Unknown Object (File)
Sun, Nov 17, 2:43 AM
Unknown Object (File)
Mon, Nov 4, 7:34 AM
Unknown Object (File)
Oct 26 2024, 7:18 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T6695: Differential view for adding an empty file looks wrong
Commits
Restricted Diffusion Commit
rP10a84d66dbc9: Show a more tailored message when adding empty files
Summary

Fixes T6695. Tailor this message.

Test Plan

Screen_Shot_2015-03-08_at_5.46.56_PM.png (226×1 px, 19 KB)

Diff Detail

Repository
rP Phabricator
Branch
uni31
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4813
Build 4829: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28933.Mar 9 2015, 12:47 AM
epriestley retitled this revision from to Show a more tailored message when adding empty files.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T6695: Differential view for adding an empty file looks wrong.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 9 2015, 12:47 AM
chad accepted this revision.Mar 9 2015, 2:36 AM
chad added a reviewer: chad.
This revision is now accepted and ready to land.Mar 9 2015, 2:36 AM
Closed by commit rP10a84d66dbc9: Show a more tailored message when adding empty files (authored by epriestley, committed by epriestley). · Explain WhyMar 9 2015, 5:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
__tests__/
data/
3 lines
5 lines
5 lines
parser/
16 lines

Diff 28933

View Options

src/applications/differential/__tests__/data/empty.diff

Loading...
View Options

src/applications/differential/__tests__/data/empty.diff.one.expect

Loading...
View Options

src/applications/differential/__tests__/data/empty.diff.two.expect

Loading...
View Options

src/applications/differential/parser/DifferentialChangesetParser.php

Loading...
Phabricator · Built by Phacility