Page MenuHomePhabricator

Reduce code duplication for inline "Undo"
ClosedPublic

Authored by epriestley on Mar 8 2015, 10:28 PM.
Tags
None
Referenced Files
F15581858: D12019.id28928.diff
Wed, May 7, 1:42 PM
F15538822: D12019.diff
Thu, Apr 24, 9:43 PM
F15504745: D12019.id28928.diff
Mon, Apr 14, 8:17 PM
F15470756: D12019.id28943.diff
Apr 5 2025, 12:49 AM
F15456222: D12019.diff
Mar 30 2025, 7:59 AM
F15429596: D12019.id28928.diff
Mar 24 2025, 3:04 AM
F15427572: D12019.diff
Mar 23 2025, 2:59 PM
F15422199: D12019.diff
Mar 22 2025, 6:35 AM
Subscribers

Details

Summary

Ref T2009. This is another almost-identical copy of the row scaffolding, which has the same 1up/2up bugs as the 8 other copies of this code.

Turn the "undo" element into an InlineCommentView so we can scaffold it.

Then, scaffold it with the same code as everything else.

Test Plan

Hit "Undo", swapped from 1up to 2up, hit "undo" again, swapped back, tried left/right, everything rendered with proper scaffolding.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Reduce code duplication for inline "Undo".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad edited edge metadata.
chad added inline comments.
src/infrastructure/diff/view/PHUIDiffInlineCommentUndoView.php
38

pht

This revision is now accepted and ready to land.Mar 8 2015, 11:32 PM
This revision was automatically updated to reflect the committed changes.