Page MenuHomePhabricator

Explicitly track inline comment reply threading
ClosedPublic

Authored by epriestley on Mar 8 2015, 8:09 PM.

Details

Summary

Ref T1460. Track and store which comments are threaded replies to other comments, vs merely appearing on the same lines.

This doesn't actually write hasReplies yet, since that needs to happen when we un-draft comments on submission.

Test Plan

Made inline comments in Differential and Diffusion, including replies. Replies were marked as "Is Reply".

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 28926.Mar 8 2015, 8:09 PM
epriestley retitled this revision from to Explicitly track inline comment reply threading.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan accepted this revision.Mar 9 2015, 5:20 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 9 2015, 5:20 PM
This revision was automatically updated to reflect the committed changes.