Differential D12014

Fix a few minor bugs in Auth Providers
ClosedPublic
Actions

Authored by chad on Mar 8 2015, 4:33 PM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T7496: "Add Providers" should be greyed out if not allowed
T7511: Wrong auth provider row height in the list

Commits

Restricted Diffusion Commit
rP6608eea91dd4: Fix a few minor bugs in Auth Providers

Summary

Fixes T7496, T7511. Sets text for registration is not enabled, sets can_manage on add_provider button.

Test Plan

Test with a logged in admin and logged in normal joe user.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 28921.Mar 8 2015, 4:33 PM

chad retitled this revision from to Fix a few minor bugs in Auth Providers.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added tasks: T7511: Wrong auth provider row height in the list, T7496: "Add Providers" should be greyed out if not allowed.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 8 2015, 4:33 PM

epriestley accepted this revision.Mar 8 2015, 5:34 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 8 2015, 5:34 PM

Closed by commit rP6608eea91dd4: Fix a few minor bugs in Auth Providers (authored by chad, committed by chad). · Explain WhyMar 8 2015, 6:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

controller/

config/

PhabricatorAuthListController.php

7 lines

Diff 28922

View Options

src/applications/auth/controller/config/PhabricatorAuthListController.php

Fix a few minor bugs in Auth ProvidersClosedPublicActions