Page MenuHomePhabricator

Use ChangesetListView on Differential standalone view
ClosedPublic

Authored by epriestley on Mar 8 2015, 11:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 12, 10:01 PM
Unknown Object (File)
Tue, Apr 9, 8:13 AM
Unknown Object (File)
Tue, Apr 2, 9:41 AM
Unknown Object (File)
Mar 20 2024, 5:12 PM
Unknown Object (File)
Feb 16 2024, 1:06 AM
Unknown Object (File)
Feb 4 2024, 6:59 PM
Unknown Object (File)
Jan 16 2024, 7:40 PM
Unknown Object (File)
Jan 9 2024, 4:51 PM
Subscribers

Details

Summary

Fixes T4452. Ref T2009. There's a hierarchy of changeset rendering power: only low-level calls, use of ChangesetDetailView, then use of ChangesetListView (a list of DetailViews).

Prior to work here, the various changeset rendering controllers got their hands dirty to varying degrees, with some using only the lowest-level rendering pipeline:

  • Phriction: no view (lowest level)
  • Diffusion: DetailView
  • Differential Changeset: DetailView
  • Differential Diff: ListView
  • Differential Revision: ListView

I brought Phriction up to use DetailView, but want to bring everything all the way up to use ListView. Each composition layer adds more features to diff browsing. In particular, this change enables "Highlight As", switching 1up vs 2up, adding inlines, etc., on the standalone view.

Test Plan
  • Viewed a changeset standalone. Could change highlighting, switch 1up vs 2up, add and edit inlines, etc.
  • Viewed a revision; no behavioral changes.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Use ChangesetListView on Differential standalone view.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 9 2015, 5:14 PM
This revision was automatically updated to reflect the committed changes.