Page MenuHomePhabricator

Make inline reticle code more general and robust
ClosedPublic

Authored by epriestley on Mar 7 2015, 7:16 PM.
Tags
None
Referenced Files
F13176051: D12009.diff
Wed, May 8, 9:55 AM
F13175977: D12009.diff
Wed, May 8, 9:22 AM
Unknown Object (File)
Tue, May 7, 8:10 AM
Unknown Object (File)
Mon, May 6, 1:58 PM
Unknown Object (File)
Fri, May 3, 7:52 AM
Unknown Object (File)
Thu, Apr 25, 1:49 AM
Unknown Object (File)
Mar 1 2024, 2:19 PM
Unknown Object (File)
Mar 1 2024, 11:52 AM
Subscribers

Details

Summary

Ref T2009. Currently, the code which draws the reticle is sort of implicitly hard-coded with some of the rules for the 2up view.

Instead, use general rules:

  • Start selection at the next <td />.
  • End selection at the rightmost adjacent <td />.

These rules work in all cases.

Test Plan
  • Activated reticle in 1up and 2up views by clicking line numbers and hovering over comments. It now draws correctly.
  • Dragged over line ranges in 1up and 2up views, saw accurate reticle.

Diff Detail

Repository
rP Phabricator
Branch
uni21
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4799
Build 4815: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Make inline reticle code more general and robust.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 7 2015, 7:33 PM
This revision was automatically updated to reflect the committed changes.