Page MenuHomePhabricator
Differential D12008

Fix Conpherence durable scrollbar with no USB devices
ClosedPublic
Actions

Authored by epriestley on Mar 7 2015, 5:46 PM.
Tags
None
Referenced Files
F13251378: D12008.id28911.diff
Fri, May 24, 10:45 PM
F13249647: D12008.id28909.diff
Fri, May 24, 10:10 AM
F13246039: D12008.id28909.diff
Thu, May 23, 7:16 AM
F13224897: D12008.diff
Sun, May 19, 11:52 AM
F13213650: D12008.id.diff
Fri, May 17, 7:58 AM
F13213008: D12008.diff
Fri, May 17, 7:16 AM
Unknown Object (File)
Tue, Apr 30, 4:49 PM
Unknown Object (File)
Tue, Apr 30, 4:49 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T7014: Annouce Persistent Chat option in Conpherence
Commits
Restricted Diffusion Commit
rP9ba430cca9e3: Fix Conpherence durable scrollbar with no USB devices
Summary

Ref T7014.

When no devices are connected, we don't meaningfully activate JX.Scrollbar (by design), but there was no fallback overflow CSS.

Also massage a couple of other CSS things to get sliiightly less broken behavior.

Test Plan
  • Disconnected USB devices; scrolled.
  • Connected USB devices; scrolled.

Diff Detail

Repository
rP Phabricator
Branch
scroll2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4796
Build 4812: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28907.Mar 7 2015, 5:46 PM
epriestley retitled this revision from to Fix Conpherence durable scrollbar with no USB devices.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
epriestley added a task: T7014: Annouce Persistent Chat option in Conpherence.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 7 2015, 5:46 PM
epriestley updated this revision to Diff 28908.Mar 7 2015, 5:47 PM
  • Slightly smaller change.
chad accepted this revision.Mar 7 2015, 5:49 PM
chad edited edge metadata.
chad added inline comments.
webroot/rsrc/css/application/conpherence/durable-column.css
80

needed?

This revision is now accepted and ready to land.Mar 7 2015, 5:49 PM
epriestley added inline comments.Mar 7 2015, 5:53 PM
webroot/rsrc/css/application/conpherence/durable-column.css
80

well I kind of got to know it and we're pretty good friends now

epriestley updated this revision to Diff 28909.Mar 7 2015, 5:53 PM
epriestley edited edge metadata.
  • Remove empty CSS rule.
Closed by commit rP9ba430cca9e3: Fix Conpherence durable scrollbar with no USB devices (authored by epriestley, committed by epriestley). · Explain WhyMar 7 2015, 5:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
webroot/
rsrc/
css/
application/
base/
1 line
conpherence/
19 lines

Diff 28907

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/application/base/standard-page-view.css

Loading...
View Options

webroot/rsrc/css/application/conpherence/durable-column.css

Loading...
Phabricator · Built by Phacility