Page MenuHomePhabricator

Make images work in the unified diff view
ClosedPublic

Authored by epriestley on Mar 6 2015, 5:39 PM.
Tags
None
Referenced Files
F18106245: D12003.id.diff
Sun, Aug 10, 10:02 PM
F18048501: D12003.id.diff
Sun, Aug 3, 1:36 PM
F17886866: D12003.id28892.diff
Tue, Jul 29, 1:18 AM
F17783714: D12003.id28898.diff
Thu, Jul 24, 11:00 AM
F17762345: D12003.id.diff
Tue, Jul 22, 10:00 PM
F17730341: D12003.id28892.diff
Sat, Jul 19, 9:42 PM
Unknown Object (File)
Jun 17 2025, 7:22 AM
Unknown Object (File)
May 21 2025, 4:01 AM
Subscribers

Details

Summary

Ref T2009. Still a touch glitch-ish but essentially functional now.

Test Plan

Viewed image diffs in 1up and 2up views. Made inline comments on them.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make images work in the unified diff view.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/differential/render/DifferentialChangesetHTMLRenderer.php
578

What's with the word "Stage" here? Maybe renderImageChange ?

This revision is now accepted and ready to land.Mar 6 2015, 11:01 PM
src/applications/differential/render/DifferentialChangesetHTMLRenderer.php
582

Just this, the class is called a "stage". It's like a theatrical stage for presenting the image, not a rocket booster stage.

This revision was automatically updated to reflect the committed changes.