Page MenuHomePhabricator
Differential D12000

Remove duplicate inline scaffold in 2up renderer
ClosedPublic
Actions

Authored by epriestley on Mar 6 2015, 2:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 31, 11:38 PM
Unknown Object (File)
Wed, Jan 29, 3:14 AM
Unknown Object (File)
Wed, Jan 29, 12:15 AM
Unknown Object (File)
Fri, Jan 24, 12:58 AM
Unknown Object (File)
Fri, Jan 24, 12:58 AM
Unknown Object (File)
Fri, Jan 24, 12:58 AM
Unknown Object (File)
Fri, Jan 24, 12:58 AM
Unknown Object (File)
Thu, Jan 23, 5:21 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity
Commits
Restricted Diffusion Commit
rPf9cb366f0071: Remove duplicate inline scaffold in 2up renderer
Summary

Ref T2009. Remove the 4 (!!) copies of this code.

Test Plan
  • Added, edited, and removed inline comments in 2up view.
  • Stacked a bunch of comments on the same line and saw the JS place them correctly.
  • Created an image diff and added, edited and removed inlines on it.

Diff Detail

Repository
rP Phabricator
Branch
uni19
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/diff/view/PHUIDiffInlineCommentRowScaffold.php:24XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 4787
Build 4803: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28888.Mar 6 2015, 2:04 PM
epriestley retitled this revision from to Remove duplicate inline scaffold in 2up renderer.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 6 2015, 2:04 PM
btrahan accepted this revision.Mar 6 2015, 10:59 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 6 2015, 10:59 PM
Closed by commit rPf9cb366f0071: Remove duplicate inline scaffold in 2up renderer (authored by epriestley, committed by epriestley). · Explain WhyMar 6 2015, 11:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28888

View Options

src/applications/differential/render/DifferentialChangesetHTMLRenderer.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentRowScaffold.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffOneUpInlineCommentRowScaffold.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffTwoUpInlineCommentRowScaffold.php

Loading...
Phabricator · Built by Phacility